KRYSTALM7 commented on code in PR #140: URL: https://github.com/apache/fineract-loan-origination/pull/140#discussion_r4152858552
########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -0,0 +1,57 @@ +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +<!-- Title format: FINERACT-XXXX: Imperative description (see CONTRIBUTING.md#pull-requests). --> +<!-- Commits must be signed to merge; see docs/development/gpg-commit-signing.adoc. --> + +## Description + +<!-- What changed and why. Link the JIRA ticket and any GitHub issue. --> + +JIRA: [FINERACT-](https://issues.apache.org/jira/browse/FINERACT-) Review Comment: Please remove the JIRA-specific references from this template. As discussed, GitHub issues will be the source of truth going forward, so the template should not ask contributors to add a JIRA ticket or require the PR title/commit message to start with a JIRA ID. Specifically, please remove/update: - the FINERACT-XXXX title-format comment near the 20th line. - the JIRA: [FINERACT-] field here - the checklist item requiring the PR title/commits to start with a JIRA issue Keep the Closes # field for linking the relevant GitHub issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
