Samer-Melhem-FOO opened a new pull request, #6521: URL: https://github.com/apache/fineract/pull/6521
## Description [FINERACT-2860](https://issues.apache.org/jira/browse/FINERACT-2860) `ReportWritePlatformServiceImpl.assembleSetOfReportParameterUsages` guards `id`, `parameterId` and `reportParameterName` with `JsonObject.has(name)` only. Gson's `has()` returns true for a member that is present with a JSON `null` value, and `getAsString()` / `getAsLong()` on `JsonNull` throw `UnsupportedOperationException`, so `POST /reports` (and `PUT /reports/{id}`) fail with HTTP 501 whenever a client sends an unset field as `null` instead of omitting it. This adds `&& !jsonObject.get(name).isJsonNull()` to each of the five guarded reads, so a JSON `null` is handled like an absent member. **Tests** - New `ReportWritePlatformServiceImplTest`: a report parameter with `"reportParameterName": null`, and one with `"id": null`. Both fail with `UnsupportedOperationException: JsonNull` without the fix and pass with it. - Checked manually against a local `develop` build (PostgreSQL): `POST /reports` with `"reportParameters":[{"id":"","parameterId":1,"reportParameterName":null}]` returned 501 before the change; with it, create, read back, update and delete all return 200. ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no API change) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
