Aman-Mittal commented on code in PR #641:
URL:
https://github.com/apache/fineract-backoffice-ui/pull/641#discussion_r4143923282
##########
src/app/shared/components/status-badge/status-badge.component.ts:
##########
@@ -154,7 +163,10 @@ export class StatusBadgeComponent {
value.includes('closed') ||
code.includes('rejected') ||
value.includes('rejected') ||
- code.includes('deleted')
+ code.includes('deleted') ||
+ outcome === 'failure' ||
Review Comment:
Uses includes pattern
and also optimize value.includes('closed') ||
code.includes('rejected') ||
value.includes('rejected') ||
as includes we can add multoiple vailes (I think it is LLM following
pattern) but can be optimized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
