shivaansh0610-LUFFY commented on code in PR #641:
URL:
https://github.com/apache/fineract-backoffice-ui/pull/641#discussion_r4146997378
##########
src/app/shared/components/status-badge/status-badge.component.ts:
##########
@@ -154,7 +163,10 @@ export class StatusBadgeComponent {
value.includes('closed') ||
code.includes('rejected') ||
value.includes('rejected') ||
- code.includes('deleted')
+ code.includes('deleted') ||
+ outcome === 'failure' ||
Review Comment:
Thanks, done in f4ef2aae. The chained includes() checks are now keyword
arrays (ACTIVE_KEYWORDS, PENDING_KEYWORDS, CLOSED_KEYWORDS) matched through one
matchesAny helper, and the outcomes are whole-word Sets. One small side effect:
the helper checks both code and value for every keyword, so a code-only
approved/submitted or a value-only deleted now also gets a colour. Fineract
sends both fields, so real statuses render the same. Unit tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
