adamsaghy commented on code in PR #6174:
URL: https://github.com/apache/fineract/pull/6174#discussion_r4153451383
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularInterestPoster.java:
##########
@@ -150,6 +150,17 @@ private void batchUpdateJournalEntries(final
List<SavingsAccountData> savingsAcc
savingsAccountData.getId(),
auditDatetime, auditDatetime, false, BigDecimal.ZERO, BigDecimal.ZERO,
null,
savingsAccountTransactionData.getTransactionDate(), null, userId, userId,
DateUtils.getBusinessLocalDate() });
+ } else {
Review Comment:
@bharathcgowda @Abhishek6122008
_The normal cash-based path
(CashBasedAccountingProcessorForSavings.java:167-172) posts interest as debit
INTEREST_ON_SAVINGS, credit SAVINGS_CONTROL.
With this PR, the job still inserts the interest transactions for cash-based
accounts but writes no journal entries for them. Savings balances and the
general ledger drift apart with no visible error.
Before, the job failed loudly. This turns a crash into missing accounting
entries._
Is this correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
