adamsaghy commented on PR #6174: URL: https://github.com/apache/fineract/pull/6174#issuecomment-5908245334
> @adamsaghy @bharathcgowda I went through the discussion and traced it on `develop`. I'm thinking of working on it this way: > > * **No accounting:** these accounts reach this point because the job also posts the interest itself, but `develop` already skips their journal entries, so no change needed. > * **Cash-based:** the real bug is in `selectAccountId`, which always uses the accrual-only `INTEREST_PAYABLE`/`INTEREST_RECEIVABLE` mappings (0 on cash-based). I'll fix it there and drop the skip guard. > * **Tests:** an integration test that runs the job on a cash-based product, plus an accrual case. > * **Failed-account reporting (Bharath's point):** separate ticket. Today one failure rolls back the whole batch and the job still shows as successful. > * **Query joins:** the `apm2`–`apm4` joins in the interest-posting query miss `product_type = 2`, so they can pick up a loan product's mappings. **Should I fix this in the same PR or keep it as a separate ticket?** > > Is this approach ok Can you please elaborate on `Query joins` part? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
