1cbyc opened a new pull request, #710: URL: https://github.com/apache/fineract-backoffice-ui/pull/710
## What and why Move working-days and two-factor configuration off direct `@ngx-translate/core` imports and onto the application-owned translation adapter. This removes two remaining settings-domain boundary violations while preserving reactive template translations and asynchronous notification lookup. Closes #683 ## Verification - `npm run test:unit -- --include=src/app/features/settings/working-days.component.test.ts` (4 tests) - `npm run lint:prune` - `npm run lint` - targeted ESLint and Prettier checks - `npm run i18n:check` - `npm run check:icons` - `npm run check:a11y-names` - `npm run build` (passes with the unchanged header style-budget warning) ## Screenshots Not applicable; this is an adapter-boundary refactor with no intended UI change. ## Checklist - [x] I did not hand-edit generated files under `src/app/api/`. - [x] New component or service code uses the adapter boundary in `src/app/core/adapters/` instead of direct browser globals or imperative third-party APIs. - [x] User-facing strings use translation keys. - [x] Existing focused tests cover the changed working-days template; compilation and static checks cover the two-factor component. - [x] UI workflow behavior is unchanged, so new e2e coverage is not applicable. - [x] Commits are signed. - [x] I followed the project contribution guidance. - [x] This is an issue-requested refactor and does not add or change a workflow. Co-authored-by: insisong <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
