rymghosn commented on PR #6289: URL: https://github.com/apache/fineract/pull/6289#issuecomment-5992455001
@adamsaghy Thanks, I've added `TaxGroupEditAfterComponentEndedTest` and rebased on the latest `develop`. The test end-dates a group's component, moves the business date past that end date, and then renames the group while resubmitting the ended component unchanged. On `develop` the edit is rejected. With this PR it succeeds, and the group keeps its single association. To reach this path over REST, the PR also carries the `id`/`endDate` fields on `TaxGroupComponent` from #6291, since `develop` drops both from the update request. The hunk is identical to #6291, so the two merge cleanly in either order. The swagger now also declares the `modifiedComponents` dates of the update response as dates, which is what the endpoint returns. Could you please re-review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
