pwargulak opened a new pull request, #6578: URL: https://github.com/apache/fineract/pull/6578
## Description [FINERACT-2896](https://issues.apache.org/jira/browse/FINERACT-2896) Waiving a loan charge gives no way to choose the waiver's transaction date. `LoanChargeWritePlatformServiceImpl` derives it from the charge's due date or the business date, and that date also drives the schedule recalculation and the lifecycle transition. A waiver that follows from an earlier event, such as a backdated repayment that settles the loan, therefore gets the processing date, and so does the loan's closing date. This change accepts an optional `transactionDate` (with `dateFormat`/`locale`) on `POST /loans/{loanId}/charges/{loanChargeId}?command=waive`. When it is given, it replaces the derived date for the waiver transaction, the recalculation and the lifecycle transition. It is validated in `LoanChargeValidator#validateChargeWaiverDate`: not in the future (`error.msg.loan.charge.waiver.cannot.be.a.future.date`) and not before disbursement (`error.msg.loan.charge.waiver.cannot.be.before.disbursement.date`). When it is absent, behaviour is unchanged; the existing derivation moves into `deriveWaiverTransactionDate` as is. Tests: - `LoanChargeValidatorTest` (new): absent, in-range, future and pre-disbursement dates. - `LoanChargeWritePlatformServiceImplTest`: the requested date reaches the transaction, the recalculation and the lifecycle transition; without it the derived date is kept. - `LoanWaiveChargeTest`: a backdated waiver closes the loan on the requested date (original and advanced strategies), and a future date is rejected. ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (`PostLoansLoanIdChargesChargeIdRequest` already carries `transactionDate`; `apiLive.htm` does not document the loan charge waive) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
