rymghosn opened a new pull request, #6577: URL: https://github.com/apache/fineract/pull/6577
## Description JIRA: https://issues.apache.org/jira/browse/FINERACT-2890 `AccountingRuleApiResource#createAccountingRule` / `#updateAccountingRule` bind the request body to `AccountRuleRequest` and re-serialize it before `AccountingRuleCommandFromApiJsonDeserializer` validates it. The record only declared `name`, `officeId`, `accountToDebit`, `accountToCredit` and `description`, so `creditTags`, `debitTags`, `allowMultipleCreditEntries` and `allowMultipleDebitEntries` were dropped during binding. As a result, a tag-based rule always failed with `validation.msg.accountToCredit.or.creditTags.required` / `validation.msg.accountToDebit.or.debitTags.required`, and the multiple-entry flags were ignored on update. This change adds the four fields to the record. The command serializer omits null components, so account-based requests produce the same command JSON as before, and update keeps its "parameter present" semantics. ### Tests - New `AccountRuleRequestSerializationTest` (`fineract-accounting`) round-trips the record through `ExcludeNothingWithPrettyPrintingOffJsonSerializerGoogleGson` into the real create/update validators. It covers a tag-based request (tags and flags kept, validation passes), an account-based request (unchanged JSON, validation passes) and a request with neither (still rejected). 3/3 pass; `spotlessJavaCheck` passes. - Live red/green against a local stock build: _in progress, results will be added here._ ### API No new endpoint. The `POST`/`PUT /v1/accountingrules` request schema (generated from the record via `@Schema(implementation = AccountRuleRequest.class)`) now also lists `creditTags`, `debitTags`, `allowMultipleCreditEntries` and `allowMultipleDebitEntries`, which the validator already accepted. ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no new API; the request schema picks up the fields from the record) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
