pwargulak opened a new pull request, #6584: URL: https://github.com/apache/fineract/pull/6584
## Description [FINERACT-2899](https://issues.apache.org/jira/browse/FINERACT-2899) `POST /loans/{loanId}/transactions/{transactionId}?command=undo` (a transaction adjustment with `transactionAmount` 0) is accepted for a `WAIVE_CHARGES` transaction and returns 200. The transaction is marked reversed, but the charge keeps its waived state and waived amount. The loan is left inconsistent with no error reported, and it cannot be repaired through the API afterwards: undo-waive refuses the waiver as already reversed. An adjustment with a non-zero amount is already refused for this transaction type; only the zero-amount undo got through. This change rejects any adjustment or undo of a `WAIVE_CHARGES` transaction in `LoanWritePlatformServiceJpaRepositoryImpl#adjustLoanTransaction`, as is already done for interest refund transactions. The error points to undo-waive (`PUT /loans/{loanId}/transactions/{transactionId}`), which restores the charge together with the transaction. Every other transaction type is unchanged. `LoanWritePlatformServiceJpaRepositoryImplTest` gains a test that an adjustment of a waiver is rejected with that message and the waiver is not reversed. It fails without the change. ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no API change) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
