avivijay19 opened a new pull request, #6593:
URL: https://github.com/apache/fineract/pull/6593

   ## Description
   
   Fixes the Admin Organisation gaps from FINERACT-2828. Offices now show 
parentId/parentName and the office update request takes parentId, tellers show 
description/endDate, holidays show description/reschedulingType, and GET 
/holidays/template has a response schema. Its operationId is now 
retrieveRepaymentScheduleUpdationTypeOptions, the old misspelled name is kept 
as an alternative operationId so existing Java client calls still work. The 
teller request documented status as the enum string, which the server rejects 
with 400; it is now the numeric code (100/300/400/600).
   
   The staff edit item was already handled by FINERACT-2288, but since that 
change PUT /staff ignored joiningDate. It is applied again, with 
dateFormat/locale on the request, and covered by a unit and an integration 
test. The currencies item is already fixed on develop.
   
   #6484 covers part of this ticket (teller description/endDate, holiday 
description, office parentName). This PR also fixes the teller status type, 
which still blocks teller creation there, and the staff joiningDate update.
   
   ## Checklist
   
   - [x] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [x] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [x] Create/update [unit or integration 
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the 
changes made.
   - [x] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [x] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   - [x] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 Large changes can be made in a branch, with assistance. Ask for help on the 
[developer mailing list](https://fineract.apache.org/#contribute).
   - [x] If merging this PR resolves a JIRA issue, I will mark that issue as 
resolved and set "Fix Version/s" appropriately.
   - [ ] I followed the [AI 
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to