rk-roshan-kr commented on PR #6593: URL: https://github.com/apache/fineract/pull/6593#issuecomment-6044963011
Hi @avivijay19, thanks for tackling these OpenAPI gaps and restoring the staff `joiningDate` update! Just reading through in my free time and noticed one small detail that might be helpful: In `StaffUpdateRequest`, `locale` was added: ```java private String locale; private String dateFormat; ``` However, in `StaffWriteServiceImpl.java`, `request.getLocale()` doesn't seem to be passed to the mapper: ```java var joiningDate = dateMapper.map(request.getJoiningDate(), request.getDateFormat()); ``` Since `StaffDateMapper` currently relies on `DateTimeFormatter.ofPattern(...)` (which falls back to the JVM's system default locale), date patterns that use month names (such as `dd MMMM yyyy`) could run into a `DateTimeParseException` if deployed in environments where the host JVM locale isn't English or doesn't match the requested locale. Might be worth forwarding `locale` to `dateMapper` as well. Just a friendly thought from a fellow contributor—hope it helps! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
