Ashutosh-Panda2004 opened a new pull request, #6594:
URL: https://github.com/apache/fineract/pull/6594

   ## Description
   
   Documents the Center fields that the API already returns but that are 
missing from the OpenAPI schemas (FINERACT-2831).
   
   ### Changes
   
   * Added `accountNo` to `GetCentersPageItems` and `GetCentersCenterIdResponse`
   * Added `activationDate` and `staffName` to `GetCentersCenterIdResponse`
   * Added `submittedOnDate` to `PostCentersRequest` (the create validator 
already accepts it; `PostGroupsRequest` documents it)
   * Added `externalId` and `staffId` to `PutGroupsGroupIdRequest` and its 
changes object, since the web app sends both when editing a center through 
`/v1/groups/{id}` and the group update command already handles them
   
   The `/centers/{id}/notes` item from the ticket is not covered here: those 
endpoints are served by the generic notes resource 
(`/v1/{resourceType}/{resourceId}/notes`), so there is no centers-specific 
operation in the generated OpenAPI to document.
   
   ### Testing
   
   * The two changed files compile with javac against the Swagger annotations.
   * I could not run the Gradle build/spotless locally (network restrictions in 
my environment), so CI will have to confirm those.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to