rk-roshan-kr commented on PR #720:
URL:
https://github.com/apache/fineract-backoffice-ui/pull/720#issuecomment-6044269731
Hi @parvarh26,
Thanks for taking this up and translating the COMMON section into Hindi! The
translations look solid and adhere closely to Indian banking terminology.
A few quick, constructive suggestions to help get this and the follow-ups
smoothly merged:
1. **Typo in `COMMON.OVERPAID`**:
At line 107 of `hi.json`, `OVERPAID` was changed from `अधिक भुगतान` to
`अधिक्ता भुगतान`. "अधिक्ता" appears to be a typo—`अधिक भुगतान` (or `अतिरिक्त
भुगतान`) is the correct phrase.
2. **Ratcheting the Coverage Baseline**:
The repository tracks coverage in `scripts/i18n-coverage.json` via
`scripts/check-translations.mjs`. When increasing translation coverage, running:
```bash
node scripts/check-translations.mjs --update
```
and committing the updated `scripts/i18n-coverage.json` locks in your new
coverage percentage so future changes cannot regress.
3. **Rebase Note for #721 and #722**:
Since #720, #721, and #722 all branched from `main` and modify adjacent
sections of `src/assets/i18n/hi.json`, once #720 merges, #721 and #722 will
likely hit git merge conflicts. Rebasing #721 and #722 on `main` after #720
lands will keep the history clean.
Great work on expanding Hindi locale coverage!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
