Aman-Mittal opened a new pull request, #163:
URL: https://github.com/apache/fineract-consumer-facing/pull/163
Fixes #161
## What
- **Spec.** The vendored Fineract spec (`1.15.0-SNAPSHOT`) is replaced with
the one shipped in `apache/fineract:4a61d7c218413eca8310d30b098722047e891bb7`,
the current `develop` build (`1.16.0-SNAPSHOT`). It is the
`/app/resources/static/fineract.json` file from that image.
- **Image.** `consumer/compose.yaml` is pinned to that same image, so the
generated client and the Fineract it is tested against come from one build.
`FINERACT_IMAGE_TAG` overrides the tag, for example to `develop` for a nightly
upstream check.
- **Renamed operationIds.** Upstream renamed several operationIds. Paths and
parameters are unchanged, and the BFF call sites, unit tests and the Cucumber
seeder are updated:
| Old | New |
|---|---|
| `calculateLoanScheduleOrSubmitLoanApplication` |
`calculateOrSubmitLoanApplication` |
| `modifyLoanApplication` | `updateLoanApplication` |
| `stateTransitions` | `handleCommandsLoan` |
| `retrieveLoan` | `retrieveOneLoan` |
| `retrieveTransactionsByLoanId` | `retrieveAllLoanTransactions` |
| `retrieveTransaction` | `retrieveOneLoanTransaction` |
| `retrieveLoanCharge` | `retrieveOneLoanCharge` |
| `retrieveLoanProductDetails` | `retrieveOneLoanProduct` |
| `searchTransactions` | `searchSavingsAccountTransactions` |
| `retrieveOne_6` | `retrieveOneAccountTransfer` |
| `retrieveCodes` | `retrieveAllCodes` |
- **Savings workaround removed.** `GET
/savingsaccounts/{id}/transactions/{txnId}` now declares a
`SavingsAccountTransactionData` response. The String + `ObjectMapper`
workaround in `SavingsQueryServiceImpl`, and its TODO, are removed.
## Why not a release tag
Docker Hub publishes no `apache/fineract` image newer than `1.12.1`;
1.13–1.15 have no image. The choice was between testing against `develop` or
keeping a spec three releases ahead of its runtime.
## Testing
Run locally against `apache/fineract:4a61d7c218…`:
- `./gradlew test`: 479 tests, 0 failures.
- `./gradlew cucumber`: 77 scenarios (340 steps), all passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
