Aman-Mittal opened a new issue, #170: URL: https://github.com/apache/fineract-consumer-facing/issues/170
This repository runs no static analysis beyond the compiler and the frontend's base ESLint configs. The sibling projects already do more: - **Fineract core** runs Error Prone, SpotBugs (with the SLF4J bug patterns), Modernizer, Checkstyle and Spotless, and publishes to SonarCloud. - **apache/fineract-backoffice-ui** uses `eslint-plugin-unicorn`, `eslint-plugin-security` and `eslint-plugin-import`, plus a local cognitive-complexity rule. These replaced `eslint-plugin-sonarjs`, which is LGPL-3.0-only (Category X). **Proposal:** - **BFF:** add Error Prone, SpotBugs and Modernizer with Fineract core's versions and settings. Exclude generated code, and give each exclusion a stated reason. - **Frontend:** add the back-office UI's plugin set and its cognitive-complexity rule (threshold 15). - **CI:** run them, and keep the SpotBugs reports as artifacts. Spotless and Checkstyle would reformat or flag most existing code, so they are left for separate changes. Publishing to SonarCloud as core does needs a project and token provisioned by ASF Infra, so it is out of scope here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
