Kollishion opened a new pull request, #196:
URL: https://github.com/apache/fineract-consumer-facing/pull/196
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!-- Commits must be signed to merge — see
CONTRIBUTING.md#signing-your-commits if you haven't set this up. -->
<!--
New feature, or a change to what a consumer can see or do?
Apache Fineract decides those on its developer mailing list, not in a pull
request. A PR
that arrives with a thread behind it is reviewed on its merits; one that
proposes something
nobody has seen spends its first round of review on the proposal instead
of the code.
Subscribe [email protected] (blank email)
Post [email protected]
Archive https://lists.apache.org/[email protected]
Chat https://matrix.to/#/%23apache-fineract-dev:matrix.org
Bug fixes, refactors and test work need none of this.
Found a security problem? Do not open a PR or an issue: see SECURITY.md.
-->
## What and why
Renamed three command-side data classes to follow the CQRS naming
conventions documented in `AGENTS.md`. Updated all affected references,
including service implementations, adapters, and tests.
Closes #187
## Verification
- `git diff --cached --check` — passed.
- Reviewed the renamed classes and updated references.
- Gradle architecture and full tests could not be completed because
`generateFineractClient` failed with a Java heap space error in the local
environment.
- No UI changes; Docker-based E2E testing is not applicable.
## Screenshots
Not applicable — backend-only refactoring.
## AI assistance (optional)
- Tool / model: OpenAI ChatGPT
- Harness / workflow: Assistance with code review, Git commands, and PR
preparation. Changes were reviewed locally by the contributor.
## Checklist
- [x] I did not hand-edit generated files under
`frontend/src/openapi-client/`.
- [x] Backend code follows the feature and CQRS layout in `AGENTS.md`.
- [x] I did not add entries to a lint or architecture baseline to get the
build passing.
- [x] User-facing strings use translation keys.
- [ ] I added or updated tests appropriate to this change, or explained why
tests were not needed.
- [x] UI workflow changes include suitable e2e coverage, including
real-backend testing where relevant.
- [ ] Commits are signed — see Signing your commits in CONTRIBUTING.md.
- [x] I followed the AI-assisted contributions guidance.
- [x] If this adds a feature or changes what a consumer can see or do, I
raised it on the dev mailing list first, or it is a bug fix, refactor or test
change, where that does not apply.
Checklist
[x] I did not hand-edit generated files under frontend/src/openapi-client/.
[x] Backend code follows the feature and CQRS layout in AGENTS.md.
[x] I did not add entries to a lint or architecture baseline to get the
build passing.
[x] User-facing strings use translation keys.
[] I added or updated tests appropriate to this change, or explained why
tests were not needed.
[x] UI workflow changes include suitable e2e coverage, including
real-backend testing where relevant.
[] Commits are signed — see Signing your commits in CONTRIBUTING.md.
[x] I followed the AI-assisted contributions guidance.
[x] If this adds a feature or changes what a consumer can see or do, I
raised it on the dev mailing list first, or it is a bug fix, refactor or test
change, where that does not apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
