Kollishion commented on PR #196: URL: https://github.com/apache/fineract-consumer-facing/pull/196#issuecomment-6152720298
Thanks for the feedback! I’m working on these changes. It may take some time to go through the files, remove the freeze wrapper and frozen violations store, rebase the changes, and update modules.adoc. I’ll push the updates once everything is done. On Mon, Oct 12, 2026 at 3:03 AM Edward Kang ***@***.***> wrote: > *edk12564* left a comment (apache/fineract-consumer-facing#196) > <https://github.com/apache/fineract-consumer-facing/pull/196#issuecomment-6114013272> > > @Kollishion <https://github.com/Kollishion> Thanks for the contribution! > The renames are clean and the test update is appreciated. > > However, could you also remove the freeze wrapper from ArchUnit tests, and > remove the archunit store of frozen violations now that the issue is fixed. > Please rebase new changes to see these. Also please update modules.adoc as > well. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/fineract-consumer-facing/pull/196?email_source=notifications&email_token=A6CLPYQJTLPNF7ECEQ64QMD5TP4CFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMJRGQYDCMZSG4ZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6114013272>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/A6CLPYXWZCNJ5HFJGTPOD335TP4CFAVCNFSNUABGKJSXA33TNF2G64TZHMYTENBUGIZDMNJQG45US43TOVSTWNJXHEZTGNBXGEZTJILWAI> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/A6CLPYSRIGVSBARBW6PRPTD5TP4CFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMJRGQYDCMZSG4ZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> > and Android > <https://github.com/notifications/mobile/android/A6CLPYX4XEMAAIMFXFH4KUL5TP4CFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMJRGQYDCMZSG4ZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. > Download it today! > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
