shivanagendrakore opened a new pull request, #199:
URL: https://github.com/apache/fineract-consumer-facing/pull/199
## What changed and why
Migrates the auth screens behind the I18N adapter boundary, following the
steps in #172 ("How to migrate a component"). Behaviour is unchanged: the pipe
resolves the same keys through the same catalogue.
Closes #174
## Changes (4 files)
- `login.component.ts`, `forgot-password.component.ts`: import
`TranslatePipe` from `../../core/adapters` instead of `@ngx-translate/core`,
and rename every template `| translate` to `| appTranslate` (7 + 9 usages). In
`forgot-password.component.ts` the pipe joins the existing `OVERLAY` import
from the adapters. One login template line was re-wrapped by Prettier because
`appTranslate` pushed it past the print width.
- `forgot-password.component.spec.ts`: `provideTranslateService()` replaced
with `...provideI18nTesting()` from `../../testing/i18n-testing`, matching
`i18n.adapter.spec.ts`.
- `eslint-suppressions.json`: pruned with `npm run lint:prune`; the three
`features/auth` entries are gone (shrink-only baseline, 27 → 24 files).
The `I18nService.translate()` calls in `forgot-password.component.ts` are
untouched — that service is application code, not the ngx-translate library
import the lint rule forbids. `login.component.spec.ts` only tests the pure
`allowedReturnUrl` helper, so it needs no i18n provider.
## Verification (Node 22, per `frontend/.nvmrc`)
- `npm run lint` → passes (no output).
- `npm run i18n:check` → "i18n check passed".
- `npx prettier --check` on the touched files → clean after formatting.
- `npm test` could not run in my environment: it needs the generated
`@bff/client` (`frontend/src/openapi-client`, gitignored), which requires
bringing up the backend stack with Docker + JDK 25 as the `unit` CI job does. I
confirmed the untouched base fails identically (`TS2307: Cannot find module
'@bff/client'`), so this is a local setup gap, not a regression from this
change — CI will exercise the specs, including the migrated
`ForgotPasswordComponent` suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
