[ 
https://issues.apache.org/jira/browse/FINERACT-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18126546#comment-18126546
 ] 

raashed commented on FINERACT-2536:
-----------------------------------

Hi [~victorromero], thanks for filing this with the video. I'd like to work on 
it if it's still free. [~aleks], is anyone still on this? I couldn't find a PR 
from them.

I looked at develop, and I think I can see why the hook never fires. Webhook 
events are only published by the legacy pipeline, in 
SynchronousCommandProcessingService.publishHookEvent(). Since FINERACT-2246, 
DocumentApiResource sends create, update and delete through the new 
CommandDispatcher instead. That pipeline has before/after/error hooks (the 
audit module uses them), but nothing there publishes a HookEvent. If that's 
right, every resource already moved to the new command processing has the same 
gap, not just DOCUMENTS.

I see two ways to fix it: a CommandHook in the new pipeline that publishes the 
HookEvent the same way the legacy path does, which fixes all the migrated 
resources at once, or something specific to documents. Which would you prefer? 
I haven't reproduced it locally yet and will do that first. Could you assign 
the ticket to me?

> Fix the Hook for DOCUMENTS
> --------------------------
>
>                 Key: FINERACT-2536
>                 URL: https://issues.apache.org/jira/browse/FINERACT-2536
>             Project: Apache Fineract
>          Issue Type: Task
>            Reporter: Victor Romero
>            Priority: Major
>              Labels: beginner, beginner-friendly
>
> Fix the Hook for DOCUMENTS
>  
> After creating a hook for sending the events while doing any activity on the 
> DOCUMENTS entity, this is not trigger, it is expected to receive the event in 
> the listener endpoint but it is not working
>  
> Video showing the error: https://youtu.be/zkfeI3G_TOw
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to