mariiaKraievska commented on code in PR #6604: URL: https://github.com/apache/fineract/pull/6604#discussion_r4259073769
########## fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanDelinquencyRangeScheduleServiceImpl.java: ########## Review Comment: Could you please check this asymmetry, and if valid fix it? shrinkPeriodsForPause now keeps restart fromDates fixed via restartResetDates (including undone SNP resets). extendPeriodsForPause still does if (fromDate.isAfter(pauseStart)) fromDate += pauseDays with no boundary. After an undone startNewPeriod reset the cut stays, but validateNotBeforeReset only looks at active resets — so a later pause starting before that (undone) reset date is allowed and will slide the restarted period off the reset date again. Please mirror the shrink guard here (and protect cut periods consistently), plus a unit/E2E for pause-after-undo with pauseStart < resetDate. UC21 doesn’t catch this because its second pause starts after the restarted fromDate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
