alberto-art3ch commented on code in PR #6604: URL: https://github.com/apache/fineract/pull/6604#discussion_r4265905567
########## fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanDelinquencyRangeScheduleServiceImpl.java: ########## Review Comment: Thanks! fixed at the source rather than in `extendPeriodsForPause`. A pause can no longer start before a `startNewPeriod` reset even once it is undone, since the undo leaves the cut in place. That's the same rule active resets already had. Mirroring only the shrink guard there would have kept the restarted period in place but still extended the cut one into it. Covered by validator unit tests and E2E UC28. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
