nemux commented on PR #6643:
URL: https://github.com/apache/fineract/pull/6643#issuecomment-6153988362

   hello @Ashutosh-Panda2004, as you can see in the ticket 
https://issues.apache.org/jira/browse/FINERACT-2934 is the sugested way to 
continue. The problem is not the changes itself the situation before send the 
pull request is the questions that I put in the ticket, I think that are 
situations that needs to be discussed in the list before (because it impacts in 
global configuration), before to send the PR. I know that they are "easy 
changes" and are well focused (because they affect only the last release) but 
are changes that can impact in currect v 1.15+ installations. I think that we 
need to wait a discuse on the list before apply them because depending on the 
agreement, there can be more changes than only the "remove" of the 
FORCE_WITHDRAWAL_ON_SAVINGS_ACCOUNT_LIMIT that can leave this pull requst 
incomplete (for example, make the apropiate validations for the withdrawal, 
Adjust, Undo, Waive Charge and Pay Charge operations)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to