nemux commented on PR #6631: URL: https://github.com/apache/fineract/pull/6631#issuecomment-6189833110
Thanks, good catch @shubhamchaudhary29. My manual testing and the IT only went through the withdrawal validation flow that threws me an error (a regular withdrawal after the forced one in a simple savings product, like the ticket describes), so I had not exercised the recalculation that replaces a transaction with a copy. I'm working on a fix for copyTransaction() that now copies forceTransaction, plus an IT that makes the recalculation replace the forced withdrawal (a back-dated deposit changes its overdraft amount) and then checks that a regular withdrawal still succeeds. The test fails without the copy and passes with it. With this review im making more changes in some jobs that makes recalculations and needs to copy this flag to avoid the bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
