Cocoa-Puffs commented on PR #6610: URL: https://github.com/apache/fineract/pull/6610#issuecomment-6212063344
I've updated the liquibase numbering during the rebase. I do not have access to testrail, once QA picks up the ticket those scenarios will get testrail ids. As for the JournalEntryAggregationJobReader, RetainedEarningJobWriter concerns: That was a judgement call on my part. As WC loans were heavily WIP throughout the year and we are now reaching a point where they are close to being feature complete I assumed WC loans are not yet used in live environments and a migration is not necessary for that reason, plus the year end retained earning job is designed to run once a year at the end of it. So I do not think a migration is necessary for this. But I'll happily implement it if you think it is needed About 8 private helpers are copied verbatim from FeignTrialBalanceSummaryReportTest into FeignWorkingCapitalTrialBalanceSummaryReportTest (runReport, money, findColumnIndex, parseBigDecimal, the retained-earning config snapshot/restore, ...). Move them to a shared helper. agreed, moved them to a shared helper -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
