MarianaDmytrivBinariks commented on PR #6610: URL: https://github.com/apache/fineract/pull/6610#issuecomment-6316927773
> ## Review > Thanks for the rebase @Cocoa-Puffs. It's a clean rebase, nothing else changed in the code: 0260 went to the force-withdrawal config merge on develop, so 0261-0264 is right, and `listReports` at 86 matches develop's 85 + 1. CI is green. > > The two things from my last review are still open though: > > * The PR description is still the untouched template. Pls put the "no WC aggregation / year-end history in production" assumption in there, plus a sentence about the WC report being a parallel copy of `0237` that has to be kept in sync. > * The 4 scenarios still have `# TODO: add TestRail ID`. Is there a ticket for QA to fill these in? Let's at least link it here so it doesn't get lost. > > Heads-up, nothing to do right now: #6613, #6659 and #6691 all claim `0261` too, and #6613 also bumps `listReports` (to 87). Whoever merges second has to renumber, and the count ends up at 88. > > Thanks! thanks for review @galovics , I've added testRailId's -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
