rymghosn opened a new pull request, #6672: URL: https://github.com/apache/fineract/pull/6672
## Description JIRA: [FINERACT-2877](https://issues.apache.org/jira/browse/FINERACT-2877) `GmailBackedPlatformEmailService.sendDefinedEmail` always builds a `SimpleMailMessage`, so every email goes out as `text/plain`. A caller that puts a link in the body (for example a password reset link) gets its markup shown as literal text instead of a clickable link. Changes: - `EmailDetail` gets an `html` flag through a new 5-argument constructor. The existing 4-argument constructor is unchanged and keeps `html = false`, so current callers behave exactly as before. - When the flag is set, `sendDefinedEmail` builds a `MimeMessage` with `MimeMessageHelper` and sends the body as `text/html`. The plain-text path is untouched. Tests: new `GmailBackedPlatformEmailServiceTest` - `sendDefinedEmailSendsPlainTextByDefault`: the default path still sends a `SimpleMailMessage`. - `sendDefinedEmailSendsHtmlWhenRequested`: with the flag set, a `MimeMessage` is sent with a `text/html` body. No REST API change. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (not applicable: no API change) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
