adamsaghy commented on code in PR #6677:
URL: https://github.com/apache/fineract/pull/6677#discussion_r4303915743
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/api/LoanProductsApiResourceSwagger.java:
##########
@@ -520,7 +520,7 @@ private GetLoanProductsAmortizationType() {}
@Schema(example = "amortizationType.equal.installments")
public String code;
@Schema(example = "Equal installments")
- public String description;
+ public String value;
}
static final class GetLoanProductsInterestType {
Review Comment:
This one still documents `description` (line 535). `GET /loanproducts`
returns `GetLoanProductsResponse[]`, and `GetLoanProductsResponse.interestType`
is this class, while the server sends `LoanProductData.interestType` as
`EnumOptionData` (`id`, `code`, `value`).
The PR renames `interestType` in `GetLoanProductsInterestTemplateType`
(`/{productId}`, `/template`), but the list endpoint uses this class, so a
typed client still can't read `interestType.value` from the list. Could you
rename it to `value` here too, so the R014 for it lands in this PR along with
the others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
