DeathGun44 commented on code in PR #6677:
URL: https://github.com/apache/fineract/pull/6677#discussion_r4305598464
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/api/LoanProductsApiResourceSwagger.java:
##########
@@ -520,7 +520,7 @@ private GetLoanProductsAmortizationType() {}
@Schema(example = "amortizationType.equal.installments")
public String code;
@Schema(example = "Equal installments")
- public String description;
+ public String value;
}
static final class GetLoanProductsInterestType {
Review Comment:
Good catch, thanks. GetLoanProductsInterestType is the list endpoint's copy,
and the server sends EnumOptionData (id, code, value) there too. Renamed
description to value in the same commit, so its R014 lands here with the
others. LoanWorkbookPopulatorTest now checks the template's product row against
the typed GET /loanproducts response for all five enum options, so the list
schema has a test reading it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
