pwargulak commented on PR #6666: URL: https://github.com/apache/fineract/pull/6666#issuecomment-6265613220
Thanks both! @galovics On per-row rounding: it drifts on the normal path, not only on reversals. A 1000.00 fee with 186.991870 tax paid 500.00 + 500.00 posts 93.50 + 93.50 = 187.00, against a charge tax of 186.99, and that cent stays in the tax account. Cumulative posts 93.50 + 93.49. I'd rather keep the total exact and let a line move by a cent, the same way the EMI remainder lands on the last period. The query only runs for taxed charges and uses the loan_charge_id index. If you still prefer per-row after this, I'll switch. - The id is set: the transaction is flushed before posting. I'll add a null check and a comment on the flush dependency. - I'll add a test that fails when a repayment type is missing from the stream. - Empty set instead of null, and I'll make the flip readable. - I'll note backdated repayments in the adoc. - Agreed on the 403 fix, I'll move it to a separate PR. @adamsaghy 1. Will fix the wording for multi-component groups. 2. See above. 3. Will do it in the 403 PR. 4. and 5. Will add. 5. Will send the rate as a BigDecimal and align the figures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
