guymoyo opened a new pull request, #819:
URL: https://github.com/apache/fineract-backoffice-ui/pull/819
## What and why
Adds a French translation, `src/assets/i18n/fr.json`, covering every key in
`en.json` (2747), with placeholders unchanged. French is registered in the
language picker the same way `hi` and `ko` are (app, login page, header) and in
the date locale map. English remains the default and nothing else changes. The
i18n coverage baseline gains `fr`.
Money verbs that differ in the ledger are kept distinct. The glossary is
added to `DOCS/CI_CHECKS.md` (the i18n section) for future translators:
| English | French |
| ---------- | -------------------- |
| Cancel | Annuler (a screen or dialog only) |
| Undo | Défaire |
| Reverse | Contre-passer |
| Waive | Exonérer |
| Write off | Passer en perte |
| Charge off | Passer en non-valeur |
| Chargeback | Rétrofacturation |
Independent of the OIDC sign-in work (#370): it carries the existing
`login.sso.notImplemented` string. Whichever PR lands second adds the new
`login.sso.*` keys to `fr.json`.
## Verification
- `npm ci`, `npm run lint` (0 errors, baseline unchanged), `npm run
test:unit` (310 files, 2487 tests), `npm run build`, `npm run i18n:check` (fr
2747/2747) and `format:check` on the changed files all pass.
- Mocked Playwright (`--project=mocked e2e/login.spec.ts
e2e/oidc-login.spec.ts`) passes. Translations were checked key by key for
placeholders; no real backend was used because only string catalogues and the
language lists changed.
## Screenshots
Available on request.
## Checklist
- [x] I did not hand-edit generated files under `src/app/api/`.
- [x] New component or service code uses the adapter boundary in
`src/app/core/adapters/` instead of direct browser globals or imperative
third-party APIs.
- [x] User-facing strings use translation keys.
- [x] I added or updated tests appropriate to this change, or explained why
tests were not needed.
- [x] UI workflow changes include suitable e2e coverage, including
real-backend testing where relevant.
- [x] Commits are signed — see [Commit
Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md.
- [ ] I followed the [AI-assisted contributions
guidance](CONTRIBUTING.md#ai-assisted-contributions).
- [ ] If this adds a feature or changes a workflow, I raised it on
[[email protected]](https://lists.apache.org/[email protected])
first —
or it is a bug fix, refactor or test change, where that does not apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
