airajena commented on code in PR #102:
URL:
https://github.com/apache/fineract-business-intelligence/pull/102#discussion_r4318494750
##########
.github/workflows/ci.yml:
##########
@@ -78,25 +78,38 @@ jobs:
scripts/run_extractor_incremental.sh \
scripts/run_pipeline.sh \
scripts/stop_fineract_backend.sh \
- scripts/verify_extraction.sh
+ scripts/verify_extraction.sh \
+ scripts/bootstrap_cdc_sources.sh \
+ loadtest/run_stages.sh \
+ loadtest/verify_incremental_equivalence.sh
- name: Lint - sqlfluff
run: |
sqlfluff lint dbt/models dbt/tests \
--exclude-rules
structure.column_order,structure.join_condition_order,references.qualification
- - name: Unit tests - extractor (no database)
- run: pytest tests/unit/extractor -v
-
- - name: Unit tests - superset (no database)
- run: pytest tests/unit/superset -v
+ - name: Unit tests - extractor, control plane, superset (no database)
+ run: pytest tests/unit -v
Review Comment:
Added all four. There's an Airflow DAG integrity job and the
incremental-versus-full-refresh equivalence check. There's also a
Testcontainers suite against a real Kafka broker and PostgreSQL, covering
exactly-once, restart, rebalance, poison event, hold and fencing. CI fails if
those tests are skipped. Unit tests with fakes cover the reconciler, slot
cleanup, ownership apply, retire and the CLI approval path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
