airajena commented on code in PR #102: URL: https://github.com/apache/fineract-business-intelligence/pull/102#discussion_r4318464050
########## controlplane/secrets.py: ########## @@ -0,0 +1,60 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, + + +from __future__ import annotations + +import os +import re + +_ENV = re.compile(r"^env:([A-Za-z_][A-Za-z0-9_]*)$") +_FILE = re.compile(r"^file:(/[^:]+):([A-Za-z0-9_.-]+)$") Review Comment: Fixed. env: names must match an allowlist (FBI_SRC_* by default), and file: paths must sit under FBI_SECRET_DIR (checked with realpath). Source connections default to verify-full. The registry, connector builder and resolver now share one validator, so vault: is rejected everywhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
