budaidev commented on code in PR #6585:
URL: https://github.com/apache/fineract/pull/6585#discussion_r4323261243
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -2763,6 +2753,8 @@ private Money
processAllocationsHorizontally(LoanTransaction loanTransaction, Tr
paymentAllocationContext.setInAdvanceInstallmentsFilteringRules(
installment ->
loanTransaction.isBefore(installment.getDueDate()) &&
installment.isNotFullyPaidOff());
}
+ // An early termination accelerates what it collapses onto its date,
so on that date it is already past due
+ final boolean terminatedEarly =
loanTransaction.getLoan().isTerminatedEarlyOnDate(loanTransaction.getTransactionDate());
Review Comment:
Not intended, thanks. processPeriodsVertically now uses the same rule: on
the termination date the accelerated installment is past due and nothing is
due. The same-day repayment test is now parameterised over horizontal/vertical
and withdrawal/contract termination, so contract termination is covered too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
