somasorosdpc commented on PR #6542: URL: https://github.com/apache/fineract/pull/6542#issuecomment-6291566895
About > validateAdjustByDelta is about 80% a copy of validateAdjustTransaction, and ADJUST_BY_DELTA_SUPPORTED_PARAMETERS is identical to ADJUST_TRANSACTION_SUPPORTED_PARAMETERS. Reuse the set, and compute original + delta and reuse the absolute checks, keeping only the zero/negative-result and type checks delta-specific. The type whitelist is also checked twice (validator and the service switch). I did some refactor to reduce exact code duplication. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
