Aman-Mittal commented on code in PR #829:
URL:
https://github.com/apache/fineract-backoffice-ui/pull/829#discussion_r4385329127
##########
src/app/features/clients/kyc/client-family-member-form.component.ts:
##########
@@ -247,18 +249,38 @@ import { createPickersReady } from
'../../../shared/utils/pickers-ready';
'CLIENTS.DATE_OF_BIRTH' | appTranslate
}}</ion-label>
@if (pickersReady()) {
- <ion-datetime-button
datetime="family-dob-picker"></ion-datetime-button>
+ <ion-datetime-button datetime="family-dob-picker">
+ @if (!isEditMode && !createDateOfBirth()) {
+ <span slot="date-target">{{
+ 'CLIENTS.DATE_OF_BIRTH_NOT_SET' | appTranslate
+ }}</span>
+ }
+ </ion-datetime-button>
}
<ion-modal [keepContentsMounted]="true">
<ng-template>
<ion-datetime
id="family-dob-picker"
data-testid="family-dob-picker"
presentation="date"
+ [value]="isEditMode ? undefined :
createDateOfBirth()"
Review Comment:
For the follow-up, not this PR: on edit the picker gets `undefined` and the
placeholder is off, so editing a family member shows today's date on the button
whether or not a DOB is saved. The loaded value only goes into
`this.dateOfBirth`. That's the #747 symptom on the edit path. Worth including
in the "clear DOB on edit" follow-up issue: bind the loaded DOB in edit mode
and show "Not set" when there is none.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
