rshdhere commented on PR #6633: URL: https://github.com/apache/fineract/pull/6633#issuecomment-6455238828
Thanks @adamsaghy, you're right on both counts. 1. I checked `2ff0c62^`: `DocumentManagementApiResource` called `DocumentWritePlatformService` directly and never went through `commandsSourceWritePlatformService`, so DOCUMENT hooks never fired. I've reworded the commit message and the description to present this as a missing feature, not a regression fix. 2. I went with the first option. `WebhookCommandHookAfter` now copies `officeId`/`clientId` to the top level of the payload when the response has them, and sets `officeId` to null inside `response`, as `SynchronousCommandProcessingService` does. That way `TwilioHookProcessor` and `MessageGatewayHookProcessor` will work for migrated client commands that opt in. I added a test for this. I also updated the description to point out the remaining difference: `request` is now the serialized request DTO rather than the raw JSON body. The commit was GPG-signed, but my public key wasn't on my GitHub account, so it didn't show as verified. I've added the key and force-pushed the re-signed commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
