rshdhere opened a new pull request, #6633: URL: https://github.com/apache/fineract/pull/6633
Since FINERACT-2246 moved document management to the new command processing, creating, updating or deleting a document no longer notifies the webhooks subscribed to DOCUMENT events. Only the legacy SynchronousCommandProcessingService publishes HookEvents; the new CommandDispatcher runs its after-hooks, but none of them published one. Add a HookableCommand interface through which a command declares the entity and action its webhooks subscribe to, and an after-hook that publishes the HookEvent for such commands with the same payload fields as the legacy path. As in the legacy path, publication waits for the enclosing transaction to commit, and a failure to publish is logged without failing the command. The document commands declare DOCUMENT CREATE, UPDATE and DELETE; other migrated commands can opt in the same way. ## Description Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.) ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [X] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [X] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [X] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [X] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [X] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [X] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
