[ https://issues.apache.org/jira/browse/FLINK-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291773#comment-14291773 ]
ASF GitHub Bot commented on FLINK-1415: --------------------------------------- Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/319#discussion_r23526978 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -329,6 +330,15 @@ public void unregisterMemoryManager(MemoryManager memoryManager) { } } + protected void notifyExecutionStateChange(ExecutionState executionState, + Throwable optionalError) { --- End diff -- This also seems weird > Akka cleanups > ------------- > > Key: FLINK-1415 > URL: https://issues.apache.org/jira/browse/FLINK-1415 > Project: Flink > Issue Type: Improvement > Reporter: Till Rohrmann > Assignee: Till Rohrmann > > Currently, Akka has many different timeout values. From a user perspective, > it would be helpful to deduce all different timeouts from a single timeout > value. Additionally, the user should still be able to define specific values > for the different timeouts. > Akka uses the akka.jobmanager.url config parameter to override the jobmanager > address and the port in case of a local setup. This mechanism is not safe > since it is exposed to the user. Thus, the mechanism should be replaced. > The notifyExecutionStateChange method allows objects to access the internal > state of the TaskManager actor. This causes NullPointerExceptions when > shutting down the actor. This method should be removed to avoid accessing the > internal state of an actor by another object. > With the latest Akka changes, the TaskManager watches the JobManager in order > to detect when it died or lost the connection to the TaskManager. This > behaviour should be tested. -- This message was sent by Atlassian JIRA (v6.3.4#6332)