[
https://issues.apache.org/jira/browse/FLINK-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291785#comment-14291785
]
ASF GitHub Bot commented on FLINK-1415:
---------------------------------------
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/319#issuecomment-71455790
This is a huge change. I took a look over the code, but I don't have enough
experience with the scheduler to understand these changes.
I would suggest to merge this rather soon because its touching a lot of
code due to minor scala style changes (semicolons, removal of parentheses from
no-arg methods, unneeded { } and so on)
+1 for the added documentation to the classes!
The bug in FLINK-1453 would be more obvious with these changes were merged.
That's another motivation for me to push this pull request forward ;)
> Akka cleanups
> -------------
>
> Key: FLINK-1415
> URL: https://issues.apache.org/jira/browse/FLINK-1415
> Project: Flink
> Issue Type: Improvement
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> Currently, Akka has many different timeout values. From a user perspective,
> it would be helpful to deduce all different timeouts from a single timeout
> value. Additionally, the user should still be able to define specific values
> for the different timeouts.
> Akka uses the akka.jobmanager.url config parameter to override the jobmanager
> address and the port in case of a local setup. This mechanism is not safe
> since it is exposed to the user. Thus, the mechanism should be replaced.
> The notifyExecutionStateChange method allows objects to access the internal
> state of the TaskManager actor. This causes NullPointerExceptions when
> shutting down the actor. This method should be removed to avoid accessing the
> internal state of an actor by another object.
> With the latest Akka changes, the TaskManager watches the JobManager in order
> to detect when it died or lost the connection to the TaskManager. This
> behaviour should be tested.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
