Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/426#discussion_r25237861
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
    @@ -235,8 +252,21 @@ public OUT readRecord(OUT reuse, byte[] bytes, int 
offset, int numBytes) throws
                
                if (parseRecord(parsedValues, bytes, offset, numBytes)) {
                        // valid parse, map values into pact record
    -                   for (int i = 0; i < parsedValues.length; i++) {
    -                           reuse.setField(parsedValues[i], i);
    +                   if (pojoTypeInfo == null) {
    +                           Tuple result = (Tuple) reuse;
    +                           for (int i = 0; i < parsedValues.length; i++) {
    +                                   result.setField(parsedValues[i], i);
    +                           }
    +                   } else {
    +                           for (int i = 0; i < parsedValues.length; i++) {
    +                                   try {
    +                                           
pojoTypeInfo.getPojoFieldAt(i).field.set(reuse, parsedValues[i]);
    --- End diff --
    
    I'm not 100% sure if this also works for pojo's with private fields.
    In your testcase, all the fields are public. I'm not sure where exactly we 
are setting the fields accessible, but it might be the case that they are not 
set accessible here. 
    Can you add a private field with a getter/setter to the test pojo to 
validate this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to