Github user chiwanpark commented on a diff in the pull request:

    https://github.com/apache/flink/pull/426#discussion_r25834522
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
    @@ -64,15 +66,25 @@
        private transient int commentCount;
     
        private transient int invalidLineCount;
    +
    +   private PojoTypeInfo<OUT> pojoTypeInfo = null;
        
        
        public CsvInputFormat(Path filePath) {
                super(filePath);
    -   }       
    +   }
    +
    +   public CsvInputFormat(Path filePath, PojoTypeInfo<OUT> pojoTypeInfo) {
    +           super(filePath);
    +
    +           Preconditions.checkNotNull(pojoTypeInfo, "The TypeInformation 
is required for getting the POJO fields.");
    +           this.pojoTypeInfo = pojoTypeInfo;
    +           setAccessibleToField();
    +   }
        
        public CsvInputFormat(Path filePath, Class<?> ... types) {
    --- End diff --
    
    @fhueske I think that we can change the constructors to receive 
TypeInformation<T> instead of a Class<?>[]. How about this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to