[ 
https://issues.apache.org/jira/browse/FLINK-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352280#comment-14352280
 ] 

ASF GitHub Bot commented on FLINK-1632:
---------------------------------------

Github user vasia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/462#discussion_r26009450
  
    --- Diff: 
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
    @@ -292,7 +291,7 @@ public ExecutionEnvironment getContext() {
         * 
         * @return true if the Graph is valid.
         */
    -   public DataSet<Boolean> validate(GraphValidator<K, VV, EV> validator) {
    +   public Boolean validate(GraphValidator<K, VV, EV> validator) throws 
Exception {
    --- End diff --
    
    why not `boolean`?


> Use DataSet's count() and collect() to simplify Gelly methods
> -------------------------------------------------------------
>
>                 Key: FLINK-1632
>                 URL: https://issues.apache.org/jira/browse/FLINK-1632
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>    Affects Versions: 0.9
>            Reporter: Vasia Kalavri
>            Assignee: Andra Lungu
>            Priority: Minor
>              Labels: easyfix, starter
>
> The recently introduced count() and collect() methods of DataSet can be used 
> to simplify several Gelly methods. We can get rid of GraphUtils and also 
> simplify methods which return DataSets with single values, such as 
> numberOfVertices() and isWeaklyConnected().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to