[
https://issues.apache.org/jira/browse/FLINK-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363379#comment-14363379
]
ASF GitHub Bot commented on FLINK-1632:
---------------------------------------
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/462#issuecomment-81756505
Thanks for the revision @andralungu! This makes the Gelly methods you
changed much more user-friendly.
Since, count() and collect() are just used to return a single value instead
of a DataSet with a single value for numberOfVertices/edges, isWeaklyConnected
and validate, I don't see any serious performance implications here. Also, I
doubt a user will call numberOfVertices(), isWeaklyConnected() or validate()
more than once on the same graph :-)
Thus, if no objections, I'd like to merge this tomorrow.
> Use DataSet's count() and collect() to simplify Gelly methods
> -------------------------------------------------------------
>
> Key: FLINK-1632
> URL: https://issues.apache.org/jira/browse/FLINK-1632
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
> Affects Versions: 0.9
> Reporter: Vasia Kalavri
> Assignee: Andra Lungu
> Priority: Minor
> Labels: easyfix, starter
>
> The recently introduced count() and collect() methods of DataSet can be used
> to simplify several Gelly methods. We can get rid of GraphUtils and also
> simplify methods which return DataSets with single values, such as
> numberOfVertices() and isWeaklyConnected().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
