Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/471#issuecomment-82554365
Look good, nice test coverage and fits very well with the recent execution
mode changes.
Only downside: This pull request does contains many cases where only
whitespaces where changed, or the order of imports. This is not really helping
the reviews and clutters the change history of files and hinders git blame. I
know that some IDEs to that automatically, but it would be nice to deactivate
that in the future. Why the hell some IDEs think that adding 100 changed lines
to a file (where only one typo was fixed) would help is beyond me...
Minor comment: The JoinDeadlock test creates a dedicated input format that
does not do anything different then `ExecutionEnvironment#generateSequence`
would do, if the source parallelism was set to one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
