[ 
https://issues.apache.org/jira/browse/FLINK-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382684#comment-14382684
 ] 

ASF GitHub Bot commented on FLINK-1523:
---------------------------------------

Github user vasia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/537#discussion_r27256701
  
    --- Diff: 
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/library/LabelPropagation.java
 ---
    @@ -68,12 +70,12 @@ public LabelPropagation(int maxIterations) {
        public static final class UpdateVertexLabel<K extends Comparable<K> & 
Serializable>
                        extends VertexUpdateFunction<K, Long, Long> {
     
    -           public void updateVertex(K vertexKey, Long vertexValue,
    +           public void updateVertex(Vertex<K, Tuple3<Long,Long,Long>> 
vertex,
                                MessageIterator<Long> inMessages) {
                        Map<Long, Long> labelsWithFrequencies = new 
HashMap<Long, Long>();
     
                        long maxFrequency = 1;
    -                   long mostFrequentLabel = vertexValue;
    +                   long mostFrequentLabel = vertex.getValue().f0;
    --- End diff --
    
    `vertex.getValue()` should return the vertex value, not a Tuple3 from the 
user has to extract the vertex value :S


> Vertex-centric iteration extensions
> -----------------------------------
>
>                 Key: FLINK-1523
>                 URL: https://issues.apache.org/jira/browse/FLINK-1523
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>            Reporter: Vasia Kalavri
>            Assignee: Andra Lungu
>
> We would like to make the following extensions to the vertex-centric 
> iterations of Gelly:
> - allow vertices to access their in/out degrees and the total number of 
> vertices of the graph, inside the iteration.
> - allow choosing the neighborhood type (in/out/all) over which to run the 
> vertex-centric iteration. Now, the model uses the updates of the in-neighbors 
> to calculate state and send messages to out-neighbors. We could add a 
> parameter with value "in/out/all" to the {{VertexUpdateFunction}} and 
> {{MessagingFunction}}, that would indicate the type of neighborhood.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to