[
https://issues.apache.org/jira/browse/FLINK-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481896#comment-14481896
]
ASF GitHub Bot commented on FLINK-1523:
---------------------------------------
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/537#issuecomment-90233701
Hey @andralungu! Thanks a lot for your work on this :)
I only took a quick look at your changes for now, but it seems that all
issues are fixed.
This PR introduces a lot of changes, so I would like to look into it more
carefully. Also, it'd be great if one more person could review.
Next, I think we should add a few tests to make sure we don't break
existing functionality and that the newly introduced options work as expected.
More specifically, I would test the following:
- if no direction is given, the iteration works as before, i.e. collecting
messages from in-neighbors and sending messages to out-neighbors .
- if direction is set to IN / OUT / ALL
- if the degrees option is not set, the vertex cannot access the degree,
i.e. no method is available or an error is produced
- if the degrees option is set, the degrees can be accessed in all
supersteps and their values are correct
- combination of the above, e.g. set direction to ALL and degrees.
I guess adding those tests will be easier after we merge #547 and make the
new options part of the configuration.
> Vertex-centric iteration extensions
> -----------------------------------
>
> Key: FLINK-1523
> URL: https://issues.apache.org/jira/browse/FLINK-1523
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
> Reporter: Vasia Kalavri
> Assignee: Andra Lungu
>
> We would like to make the following extensions to the vertex-centric
> iterations of Gelly:
> - allow vertices to access their in/out degrees and the total number of
> vertices of the graph, inside the iteration.
> - allow choosing the neighborhood type (in/out/all) over which to run the
> vertex-centric iteration. Now, the model uses the updates of the in-neighbors
> to calculate state and send messages to out-neighbors. We could add a
> parameter with value "in/out/all" to the {{VertexUpdateFunction}} and
> {{MessagingFunction}}, that would indicate the type of neighborhood.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
