[ 
https://issues.apache.org/jira/browse/FLINK-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395549#comment-14395549
 ] 

ASF GitHub Bot commented on FLINK-1826:
---------------------------------------

GitHub user matadorhong opened a pull request:

    https://github.com/apache/flink/pull/569

    [FLINK-1826]Remove the redundant codes never be executed in function 
getNumPages

    Remove the code never be executed in function getNumPages, because the 
input of numBytes has be validataion by its caller of DefaultMemoryManager(long 
memorySize, int numberOfSlots, int pageSize).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matadorhong/flink FLINK-1826

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/569.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #569
    
----
commit 40261a4519578d22c51030660323ac722e822045
Author: hongsibao <[email protected]>
Date:   2015-04-04T04:56:54Z

    Remove the redundant codes never be executed in function getNumPages

----


> Remove the code never be executed in function getNumPages
> ---------------------------------------------------------
>
>                 Key: FLINK-1826
>                 URL: https://issues.apache.org/jira/browse/FLINK-1826
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>    Affects Versions: master
>            Reporter: Sibao Hong
>            Assignee: Sibao Hong
>            Priority: Minor
>             Fix For: master
>
>
> Remove the code never be executed in function getNumPages, because the input 
> of numBytes has be validataion by its caller of DefaultMemoryManager(long 
> memorySize, int numberOfSlots, int pageSize).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to