[
https://issues.apache.org/jira/browse/FLINK-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395825#comment-14395825
]
ASF GitHub Bot commented on FLINK-1826:
---------------------------------------
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/569#issuecomment-89617988
Hey, I personally like that the check is performed there even though it is
currently redundant. It is true that the `DefaultMemoryManager` is for internal
usage, but I think it is generally better be safe than sorry with these checks.
> Remove the code never be executed in function getNumPages
> ---------------------------------------------------------
>
> Key: FLINK-1826
> URL: https://issues.apache.org/jira/browse/FLINK-1826
> Project: Flink
> Issue Type: Improvement
> Components: Local Runtime
> Affects Versions: master
> Reporter: Sibao Hong
> Assignee: Sibao Hong
> Priority: Minor
> Fix For: master
>
>
> Remove the code never be executed in function getNumPages, because the input
> of numBytes has be validataion by its caller of DefaultMemoryManager(long
> memorySize, int numberOfSlots, int pageSize).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
